[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl updated this revision to Diff 88948.
kzhuravl marked 9 inline comments as done.
kzhuravl added a comment.

Address review feedback:

- Encode the address space in bitcode as n+1, with 0 being the default=None value
- Updated verifier to check that address space is only present in DW_AT_pointer_type and DW_AT_reference_type (+ relevant tests)
- Added test to check that DW_AT_address_class is not emitted in DWARF v1
- Other minor feedback (marked inline comments as done)


https://reviews.llvm.org/D29670

Files:
  bindings/go/llvm/DIBuilderBindings.cpp
  docs/AMDGPUUsage.rst
  include/llvm/IR/DIBuilder.h
  include/llvm/IR/DebugInfoMetadata.h
  lib/AsmParser/LLParser.cpp
  lib/Bitcode/Reader/MetadataLoader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/IR/AsmWriter.cpp
  lib/IR/DIBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/IR/LLVMContextImpl.h
  lib/IR/Verifier.cpp
  test/Assembler/debug-info.ll
  test/Bitcode/upgrade-pointer-address-space.ll
  test/Bitcode/upgrade-pointer-address-space.ll.bc
  test/DebugInfo/AMDGPU/pointer-address-space-dwarf-v1.ll
  test/DebugInfo/AMDGPU/pointer-address-space.ll
  test/Verifier/diderivedtype-address-space-atomic-type.ll
  test/Verifier/diderivedtype-address-space-const-type.ll
  test/Verifier/diderivedtype-address-space-friend.ll
  test/Verifier/diderivedtype-address-space-inheritance.ll
  test/Verifier/diderivedtype-address-space-member.ll
  test/Verifier/diderivedtype-address-space-ptr-to-member-type.ll
  test/Verifier/diderivedtype-address-space-restrict-type.ll
  test/Verifier/diderivedtype-address-space-rvalue-reference-type.ll
  test/Verifier/diderivedtype-address-space-typedef.ll
  test/Verifier/diderivedtype-address-space-volatile-type.ll
  unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29670.88948.patch
Type: text/x-patch
Size: 46675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170217/c75574b4/attachment.bin>