[PATCH] D30022: [XRay][compiler-rt] Allow for defining defaults at compile-time

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 11:04:29 PST 2017


timshen added inline comments.


================
Comment at: lib/xray/xray_flags.cc:43
+#define XRAY_STRINGIZE(x) #x
+#define XRAY_STRINGIZE_OPTIONS(options) XRAY_STRINGIZE(options)
+  return XRAY_STRINGIZE_OPTIONS(XRAY_DEFAULT_OPTIONS);
----------------
It took me two minutes to understand why we need this. :) Maybe add a comment here?


https://reviews.llvm.org/D30022





More information about the llvm-commits mailing list