[PATCH] D30010: Improve the robustness of mmap

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 10:34:36 PST 2017

Previous message: [PATCH] D30010: Improve the robustness of mmap
Next message: [PATCH] D30010: Improve the robustness of mmap
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

pcc added a comment.

In https://reviews.llvm.org/D30010#680067, @zturner wrote:

> Actually, now that I think about it, instead of calling the parameter `IsVolatileSize`, how about just `IsVolatile`?  That includes the case that the entire file is volatile (and might disappear from a network share).


SGTM.


https://reviews.llvm.org/D30010

Previous message: [PATCH] D30010: Improve the robustness of mmap
Next message: [PATCH] D30010: Improve the robustness of mmap
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list