[PATCH] D29673: [DebugInfo] Append extended dereferencing mechanism to variables' DIExpression for targets that support more than one address space

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3187
+    unsigned AddressSpace,
+    SmallVector<int64_t, 9> &Expr) const {
+  Expr.push_back(llvm::dwarf::DW_OP_constu);
----------------
kzhuravl wrote:
> aprantl wrote:
> > MutableArrayRef?
> I have currently changed it to SmallVectorImpl. I am not sure if MutableArrayRef should be used here?
> 
> What if we decide to add more expressions before appending address space xderef? 
SmallVectorImpl is fine.


https://reviews.llvm.org/D29673