[PATCH] D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 08:10:54 PST 2017


peter.smith updated this revision to Diff 88902.
peter.smith added a comment.

Updated diff to:

- Rebased on top of https://reviews.llvm.org/D30085 (not reviewed yet) which allows us to add local symbols after globals
- Moved the addition of symbols to the GNU Hash Table to a separate member function that can be called immediately after the dynamic symbols have been added.
- Change finalizeAllocSize() to updateAllocSize(). The intention is that this will be called each time thunks are added, and immediately prior to thunks being added, to prevent the MipsGot missing an additional page.
- Hopefully addressed any review comments that still apply

I've not put a loop in for createThunks() yet as they need some work to make sure that they don't create Thunks to Thunks and loop into infinity. This would be best addressed in a later patch.


https://reviews.llvm.org/D29983

Files:
  ELF/Relocations.cpp
  ELF/Relocations.h
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h
  ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29983.88902.patch
Type: text/x-patch
Size: 20303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170217/6d6fe864/attachment.bin>


More information about the llvm-commits mailing list