[PATCH] D30092: CMake: Clean up VersionFromVCS.cmake

[Michał Górny via Phabricator via llvm-commits]

mgorny added inline comments.


================
Comment at: cmake/modules/VersionFromVCS.cmake:39
           WORKING_DIRECTORY ${SOURCE_DIR}
           TIMEOUT 5
           RESULT_VARIABLE git_result
----------------
Sorry for a bit offtopic but any idea why are we having a timeout for git commands? AFAICS they do not involve any network activity, so I don't see a good reason to timeout here. Furthermore, git can be a bit slow which makes 5 seconds kinda dangerous.


https://reviews.llvm.org/D30092