[PATCH] D29994: Use pthreads for thread-local lsan allocator cache on darwin

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/lsan/lsan_common.h:18
 
+#include "lsan_allocator.h"
 #include "sanitizer_common/sanitizer_allocator.h"
----------------
Hm...  Could we have it the other way around?  lsan_allocator.h would include lsan_common.h and GetAllocatorCache would be declared in lsan_allocator.h only.  lsan_allocator.cc would include lsan_allocator.h.  The _linux.cc and _mac.cc files would also include lsan_allocator.h.  Is there a dependency problem with that?


https://reviews.llvm.org/D29994