[PATCH] D29993: Use pthreads to store current thread id on darwin

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 17:44:06 PST 2017


kubamracek added inline comments.


================
Comment at: lib/lsan/lsan_common.h:58
 
+const u32 kInvalidTid = 0xffffff;  // Must fit into 24 bits.
+
----------------
kubamracek wrote:
> Why does this have to fit into 24 bits?
lsan_thread.cc already declared kInvalidThread as `-1`.  Can we use this declaration and just move it here?


https://reviews.llvm.org/D29993





More information about the llvm-commits mailing list