[llvm] r294993 - GlobalISel: represent atomic loads & stores via the MachineMemOperand.

[Quentin Colombet via llvm-commits]

> On Feb 16, 2017, at 9:56 AM, Ahmed Bougacha via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Asserting that a generic memory instruction has one MMO seems reasonable to me.

+1

> 
> But beyond making sure we don't drop the MMO, the fact that it's on
> the side makes it easier to introduce bugs that ignore it.  But I
> suppose that's not that different from isVolatile and whatnot in both
> IR and SDAG.
> -Ahmed
> 
> 
> On Wed, Feb 15, 2017 at 2:41 PM, Tim Northover <tnorthover at apple.com> wrote:
>>> Do we have a way to "stomp on anyone that tries" automatically?
>> 
>> Well, dropping a new "MachineMemOperandOperand" would be detected automatically when the verifier checks the instruction has the correct number of operands. Other than that, only code review; but I think it's pretty unlikely someone will break it accidentally.
>> 
>> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits