[PATCH] D30059: Refactor InlinCost.cpp in preparation for estimated speedup heuristic.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

Can you split this into separate patches that do a single refactoring? (Especially considering you have the breakdown in your descirption...) That would make it easier to review for me.



================
Comment at: lib/Analysis/InlineCost.cpp:402-404
+void CallAnalyzer::accumulateCost(int InstructionCost) {
+  Cost += InstructionCost;
+}
----------------
Of all of these, this one seems the one that doesn't really make sense on its own. I'd rather this be part of the change where it starts to make sense rather than a seemingly bad code smell being added because of some subsequent change.


https://reviews.llvm.org/D30059