[PATCH] D30053: Add function importing info from samplepgo profile to the module summary.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D30053#679264, @davidxl wrote:

> Is it better to introduce a new meta data for this, e.g. MD_inline_instance_imports ?   Can this information be directly communicated to function importer instead of relying on modifying Callgraph/profile data?


We need to expose this to the thin-link for the distributed mode, otherwise the dependent files the function importer would want to import from may not be available. So the summary-based importing analysis will need to be aware of this. Right now the solution is to trick it like we do for ICP by adding "fake" edges. The difference is that for ICP we just make indirect edges direct, but we don't really cheat on the graph structure otherwise. Here we'd create "short-circuit" edges (adding an edge foo->bar when in fact the reality is foo->baz->bar).


https://reviews.llvm.org/D30053