[PATCH] D29807: FileCheck-ize some tests in test/CodeGen/X86/

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 16:17:56 PST 2017


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM with a tiny nit pick. I'll apply the fix and submit momentarily, but mentioning it here just for posterity.



================
Comment at: test/CodeGen/X86/2005-01-17-CycleInDAG.ll:18
+  ret i32 %Z
+; CHECK-NOT: {{sub.*GLOBAL}}
 }
----------------
Tiny nit pick: you can often narrow the scope of the regex, and I often find that easier to read. So I would usually write:

  ; CHECK-NOT: sub{{.*}}GLOBAL


https://reviews.llvm.org/D29807





More information about the llvm-commits mailing list