[PATCH] D30010: Improve the robustness of mmap
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 16 13:41:10 PST 2017
rnk added a comment.
Looks right to me. I'm not familiar with the stat syscall, though, so I'd look for a reviewer for that.
================
Comment at: llvm/unittests/Support/Path.cpp:1158
+ EXPECT_TRUE(Result);
+ EXPECT_TRUE(fs::is_local(FD));
+}
----------------
I guess mounting a remote filesystem is out of scope for a unit test. :)
https://reviews.llvm.org/D30010
More information about the llvm-commits
mailing list