[PATCH] D29973: [PDB] Support following Type server records

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp:33
+
+void PDBTypeServerHandler::addSearchPath(StringRef Path) {
+  if (Path.empty() || !sys::fs::is_directory(Path))
----------------
zturner wrote:
> ruiu wrote:
> > Calling this function more than once with the same argument seems to add the same element to to `SearchPaths`. Is this a desired behavior?
> I don't feel strongly either way, if you think it's better to change it I can.
I don't have a preference, so this is fine.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp:16
+// the referenced PDB file.  If a single instance of PDBTypeServerHandler
+// encounters the same TypeServer multiple times (for example reusing one
+// PDBTypeServerHandler across multiple visitations of distinct object files or
----------------
no corresponding '('?


https://reviews.llvm.org/D29973