[PATCH] D29803: WholeProgramDevirt: Examine the function body when deciding whether functions are readnone.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 11:49:53 PST 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM, one suggestion below



================
Comment at: llvm/test/Transforms/WholeProgramDevirt/vcp-accesses-memory.ll:46
+; CHECK: define i32 @call2
+define i32 @call2(i8* %obj) {
+  %vtableptr = bitcast i8* %obj to [1 x i8*]**
----------------
Can you add comments about what these different functions are testing?


https://reviews.llvm.org/D29803





More information about the llvm-commits mailing list