[PATCH] D30046: [globalisel] Change LLT constructor string into an LLT subclass that knows how to generate it.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 10:11:07 PST 2017


ab added a comment.

In https://reviews.llvm.org/D30046#678794, @dsanders wrote:

> The main difficulty I'm having with splitting it is functions like:
>
>   static LLT scalar(unsigned SizeInBits);
>
> and other functions that return LLT. I need them to exist in both lib/CodeGen and lib/Support but I can't distribute the class declaration between the two.


Huh, I probably poorly explained my thought.  Here's an attempt: https://reviews.llvm.org/D30047

Note that it ends up including CodeGen/MVT from libSupport, which in theory is also gross, but in practice should never become a problem.  We might want to consider fixing that too though.


https://reviews.llvm.org/D30046





More information about the llvm-commits mailing list