[LNT] r295334 - Daily report: only display non empty result tables to avoid cluttering the UI.

[Arnaud A. de Grandmaison via llvm-commits]

Author: aadg
Date: Thu Feb 16 10:37:11 2017
New Revision: 295334

URL: http://llvm.org/viewvc/llvm-project?rev=295334&view=rev
Log:
Daily report: only display non empty result tables to avoid cluttering the UI.

Summary:
This is a useability fix only. Empty tables are only taking space and
this is distracting from the essential overview the daily report page is
supposed to provide. However, this could be considered controversial as
some could prefer to keep the empty tables, thus this commit review
solliciting other users' feedback to check if there is agreement.

Reviewers: kristof.beyls, cmatthews, llvm-commits

Subscribers: mcrosier

Differential Revision: https://reviews.llvm.org/D29991

Modified:
    lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html

Modified: lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html?rev=295334&r1=295333&r2=295334&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html (original)
+++ lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html Thu Feb 16 10:37:11 2017
@@ -232,6 +232,7 @@
 {%- endmacro %}
 
 {% for field,field_results in report.result_table|reverse %}
+{%- if field_results -%}
 <h3>Result Table ({{ field.name }})</h3>
 {{ result_header()+"\n  <tbody>" if not report.for_mail }}
 {%- for test,visible_results in field_results -%}
@@ -267,6 +268,9 @@
 {{ "</tbody></table><p>" if report.for_mail }}
 {%- endfor %}
 {{ "</tbody></table>" if not report.for_mail }}
+{%- else -%}
+<h3>No significant {{ field.name }} changes found.</h3>
+{%- endif -%}
 {%- endfor -%}
 
 {% endif %}