[PATCH] D24716: [Polly] DeLICM/DePRE (WIP)

[Tobias Grosser via Phabricator via llvm-commits]

grosser added a comment.

Hi Michael,

this patch looks good to me. Just two minor typos. Also, I would really appreciate if you could add some negative tests.

Best,
Tobias



================
Comment at: lib/Transform/DeLICM.cpp:1364
+
+    // Stack of elements no yet processed.
+    SmallVector<MemoryAccess *, 16> Worklist;
----------------
NOT yet processed


================
Comment at: lib/Transform/DeLICM.cpp:1537
+  /// zones, but we can only chose one. This is a greedy algorithm, therefore
+  /// the first processed claims it.
+  void greedyCollapse() {
----------------
processed ELEMENT


https://reviews.llvm.org/D24716