[llvm] r294679 - [WebAssembly] Pass an MCContext to WebAssemblyMCCodeEmitter. NFC.

[Dan Gohman via llvm-commits]

On Wed, Feb 15, 2017 at 1:48 PM, Derek Schuff <dschuff at google.com> wrote:

>
>
> On Thu, Feb 9, 2017 at 4:26 PM Dan Gohman via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: djg
>> Date: Thu Feb  9 18:14:42 2017
>> New Revision: 294679
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=294679&view=rev
>> Log:
>> [WebAssembly] Pass an MCContext to WebAssemblyMCCodeEmitter. NFC.
>>
>> Modified:
>>     llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/
>> WebAssemblyMCCodeEmitter.cpp
>>     llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/
>> WebAssemblyMCTargetDesc.cpp
>>     llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/
>> WebAssemblyMCTargetDesc.h
>>
>> Modified: llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/
>> WebAssemblyMCCodeEmitter.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/
>> WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp?
>> rev=294679&r1=294678&r2=294679&view=diff
>> ============================================================
>> ==================
>> --- llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp
>> (original)
>> +++ llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp
>> Thu Feb  9 18:14:42 2017
>> @@ -35,6 +35,7 @@ STATISTIC(MCNumFixups, "Number of MC fix
>>  namespace {
>>  class WebAssemblyMCCodeEmitter final : public MCCodeEmitter {
>>    const MCInstrInfo &MCII;
>> +  MCContext &Ctx;
>>
>
> This is causing a build warning (-Wunused-private-field). Do you have an
> imminent followup CL to use this or (if e.g. it's still blocked on review)
> should we just cast it to void in the constructor or something?
>

The followup patches are still blocked on review. A cast to void would be
fine for now. I'll add one soon, unless you get there before me :-).

Dan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170215/9c90e40e/attachment.html>