[PATCH] D29973: [PDB] Support following Type server records

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp:40
+
+Expected<bool>
+PDBTypeServerHandler::handleInternal(PDBFile &File,
----------------
ruiu wrote:
> You want to change this to `Error` and return `Error::success()` on success.
`Error` is not quite the same.  Here I want to return 3 possible pieces of information:

1. Caller should assume the type server record has been handled.
2. Caller should assume the type server record has not been handled.
3. An error occurred.   (For example the file was corrupt).

1 and 2 are distinct non-error conditions though.  In case 1, the caller stops processing this record and goes to the next one in the stream.  In case 2, caller keeps searching through the list of handlers in case another one can handle it.  But in case 3, something bad happened and the caller probably has to exit and report an error.


https://reviews.llvm.org/D29973