[PATCH] D29954: [PGO] Suspend SIGKILL for PR_SET_PDEATHSIG in profile-write

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: test/profile/Linux/prctl.c:17
+int main(int argc, char **argv)
+{
+    pid_t pid = fork();
----------------
format the test in llvm style.


================
Comment at: test/profile/Linux/prctl.c:23
+        int sum = 0;
+        /* child process: sleep 50ms and get to runtime before the 
+         * main process exits. */
----------------
50 us or microsec


================
Comment at: test/profile/Linux/prctl.c:33
+    {
+        /* parent process: sleep 10ms to get into profile runtime first. */
+        usleep(10);
----------------
10us


================
Comment at: test/profile/Linux/prctl.c:40
+// CHECK: Total functions: 1
+// CHECK: Maximum function count: 5000
+// CHECK: Maximum internal block count: 1
----------------
Just check size of profile data? It is not guaranteed that child process will have a chance to dump.


https://reviews.llvm.org/D29954