[PATCH] D30004: [InstCombin] Continue scanning loaded values through single predecessors

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 12:45:20 PST 2017


dberlin added a comment.

I'm going to ask the same question i did about the jumpthreading case:

This seems to be a thing other passes get, and do it cheaper.

I would rather see us *remove this code entirely* than extend it.  We don't need to do everything everywhere.
The testcases given are optimizations we will get elsewhere.
If there are good reasons to do this in instcombine, great, let's test those reasons :)


https://reviews.llvm.org/D30004





More information about the llvm-commits mailing list