[PATCH] D28786: [ExecutionDepsFix] Kill clearance at function entry/calls

[Marina Yatsina via Phabricator via llvm-commits]

myatsina added inline comments.


================
Comment at: test/CodeGen/X86/break-false-dep.ll:269
+;AVX-NEXT: vucomiss [[XMM4_7]], %xmm0
+  %0 = fcmp ult float %z, 0.0
+  br i1 %0, label %loop, label %fake
----------------
loladiro wrote:
> myatsina wrote:
> > Why the change? What are you testing here?
> As remarked in the other revision, this is a trick for making sure that pickBestRegister is still tested.
Well, you're no longer just testing pickBestReg, you're also testing the "xor fusion" which beats the purpose of unit tests.

Why do you think this test didn't test "pickBestReg" after your change?
But this test does need to be changes to expect a "xor" before the convert (which should be the only effect of your change on this test). Or is there some other way you've affected this test that I'm missing?


Repository:
  rL LLVM

https://reviews.llvm.org/D28786