[PATCH] D29970: opt-viewer: abbreviate long function names

[Brian Cain via Phabricator via llvm-commits]

bcain added inline comments.


================
Comment at: utils/opt-viewer/opt-viewer.py:116-117
 
         if key == 'Caller' or key == 'Callee':
             value = cgi.escape(demangle(value))
 
----------------
bcain wrote:
> anemet wrote:
> > > This will only change index and the source render's "Inline Context" column. Unfortunately, references to very long function names in remarks are not affected by this change.
> > 
> > If you abbreviated here too, I think that would do it, no?
> But it would abbreviate the entire comment, regardless of the presence/absence of a long function name.  Is that still what we want here?
Hmm, or maybe it wouldn't, actually.  I'll take a closer look.


https://reviews.llvm.org/D29970