[PATCH] D29185: [lit] Allow llvm's build and test systems to support paths with spaces

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

In https://reviews.llvm.org/D29185#675161, @chandlerc wrote:

> So, we have a system that does *not* handle spaces in paths well. I would really like to continue to use the more restrictive rules for lit test names.
>
> I'm happy to have fixes that let things be checked out and built in a path with spaces, but I'd like to require the paths *within* LLVM to continue to not have spaces. Those will work on all systems, whereas paths with spaces will make some users have a (much) harder time integrating with LLVM.


I like this constraint. Unfortunately, as a side-effect of supporting things being checked out and built in a path with spaces, this patch does add the support needed to paths with spaces within LLVM.

Do you think I need to modify the patch so that CMake/lit actively reject paths with spaces - to prevent such paths getting into llvm?


https://reviews.llvm.org/D29185