[PATCH] D29623: [ARM] Replace HasT2ExtractPack with HasDSP
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 15 03:11:46 PST 2017
samparker added a comment.
Hi Oli,
As far as I can see, instructions such as QADD aren't available for Thumb prior to T2 so predicating these instructions on IsThumb2 and HasDSP should cover them. I think the same is true for SXTAB, the difference between v7M and v7E-M targets is the HasDSP feature and the tests hopefully proved that SXTAB is only selected in the correct cases. Since HasT2ExtractPack was never defined without HasDSP, I can't see how this can break the expected functionality.
cheers
https://reviews.llvm.org/D29623
More information about the llvm-commits
mailing list