[LNT] r295160 - Daily report: display the number of tests seen near the top of the report, rather than at the bottom.

Arnaud A. de Grandmaison via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 01:02:42 PST 2017


Author: aadg
Date: Wed Feb 15 03:02:42 2017
New Revision: 295160

URL: http://llvm.org/viewvc/llvm-project?rev=295160&view=rev
Log:
Daily report: display the number of tests seen near the top of the report, rather than at the bottom.

Summary:
The usual process when looking at the daily report page is:
1. Look at which builder submitted (or not) results,
2. Look at the number of tests submitted by each builder,
3. Look at the actual regressions' details, scrolling down the page as necessary.

This commit make the daily report layout follow the logical process.

This is a useability change and functionality is not affected.

Reviewers: kristof.beyls, cmatthews

Subscribers: mcrosier

Differential Revision: https://reviews.llvm.org/D29891

Modified:
    lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html

Modified: lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html?rev=295160&r1=295159&r2=295160&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html (original)
+++ lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html Wed Feb 15 03:02:42 2017
@@ -81,6 +81,35 @@
   </tbody>
 </table>
 
+<h3>Number of Tests Seen</h3>
+<table border="1" style="{{ styles.table }}; width: {{
+                            400 + report.num_prior_days_to_include*80}}px;">
+  <thead>
+    <tr>
+      <th style="{{ styles.th }}; width: 300px;">Machine Name</th>
+    {% for i in range(report.num_prior_days_to_include)|reverse %}
+      <th style="{{ styles.th }}">Day - {{i}}</th>
+    {% endfor %}
+    </tr>
+  </thead>
+  <tbody>
+  {% for machine, nr_tests_for_machine in report.nr_tests_table %}
+  <tr class="searchable">
+    <td class="machine-name" style="{{ styles.td }}">{{machine.name}}</td>
+    {% set nr_tests_prev = None %}
+    {% for nr_tests in nr_tests_for_machine|reverse %}
+        <td style="{{ styles.td }}"
+        {%- if nr_tests_prev is not none and nr_tests_prev != nr_tests %}
+            bgcolor="#dfaf5f"
+        {% endif -%}
+            >{{nr_tests}}</td>
+        {% set nr_tests_prev = nr_tests %}
+    {% endfor %}
+  </tr>
+  {% endfor %}
+  </tbody>
+</table>
+
 {% macro get_initial_cell_value(day_result) %}
 {%- set cr = day_result.cr -%}
 {%- set test_status = cr.get_test_status() -%}
@@ -240,35 +269,6 @@
 {{ "</tbody></table>" if not report.for_mail }}
 {%- endfor -%}
 
-<h3>Number of Tests Seen</h3>
-<table border="1" style="{{ styles.table }}; width: {{
-                            400 + report.num_prior_days_to_include*80}}px;">
-  <thead>
-    <tr>
-      <th style="{{ styles.th }}; width: 300px;">Machine Name</th>
-    {% for i in range(report.num_prior_days_to_include)|reverse %}
-      <th style="{{ styles.th }}">Day - {{i}}</th>
-    {% endfor %}
-    </tr>
-  </thead>
-  <tbody>
-  {% for machine, nr_tests_for_machine in report.nr_tests_table %}
-  <tr class="searchable">
-    <td class="machine-name" style="{{ styles.td }}">{{machine.name}}</td>
-    {% set nr_tests_prev = None %}
-    {% for nr_tests in nr_tests_for_machine|reverse %}
-        <td style="{{ styles.td }}"
-        {%- if nr_tests_prev is not none and nr_tests_prev != nr_tests %}
-            bgcolor="#dfaf5f"
-        {% endif -%}
-            >{{nr_tests}}</td>
-        {% set nr_tests_prev = nr_tests %}
-    {% endfor %}
-  </tr>
-  {% endfor %}
-  </tbody>
-</table>
-
 {% endif %}
 
 {% if not only_html_body %}




More information about the llvm-commits mailing list