[PATCH] D29968: Handle .eh_frame pointing to discarded section in -r

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

Unfortunately this isn't enough to fix the Go bindings tests, it causes the final link to fail with a different error:

  bin/ld.lld: error: /tmp/lit_tmp_Sxmw_u/go-link-243494992/000000.o:(.eh_frame): FDE doesn't reference another section

You can reproduce it with your test case like this:

  $ ra/bin/ld.lld ra/tools/lld/test/ELF/Output/relocatable-eh-frame.s.tmp
  ra/bin/ld.lld: error: ra/tools/lld/test/ELF/Output/relocatable-eh-frame.s.tmp:(.eh_frame): FDE doesn't reference another section

or just pass in the _all.o from the reproducer I posted earlier.

Perhaps the simplest thing to do would be to relax the FDE checking during regular links? That doesn't sound very appealing though.


https://reviews.llvm.org/D29968