[PATCH] D29837: [LazyMachineBFI] Add testcase

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: test/CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll:2
+; RUN: llc < %s -mtriple=arm64-apple-ios7.0 -pass-remarks-analysis=asm-printer \
+; RUN:     -pass-remarks-with-hotness -debug-only=block-freq -debug-pass=Executions 2>&1 | FileCheck %s \
+; RUN:     -check-prefix=HOTNESS
----------------
davidxl wrote:
> Do you need -debug-only=block-freq here? Does it work with release build?
Yeah, I need a way to check whether BFI is being computed *here*.

This mirrors the IR test under Other/optimization-remarks-lazy-bfi.ll.



================
Comment at: test/CodeGen/AArch64/arm64-opt-remarks-lazy-bfi.ll:7
+
+; REQUIRES: asserts
+
----------------
> Does it work with release build?

No it doesn't.  This line ensures that we only run this test when asserts are enabled.


https://reviews.llvm.org/D29837