[PATCH] D27503: [XRay] Custom event logging intrinsic

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

One inline nit, I'd like to take a closer look at this though. Can you give an example of use case and lowering?

Thanks :)



================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1086
+  // Push the arguments in reverse order per x86 calling convention.
+  // FIXME(louisli): this is not in reverse -- what's the elegant way to reverse this iterator?
+  for (auto &MO : make_range(MI.operands_begin(), MI.operands_end())) {
----------------
No named fixme.


https://reviews.llvm.org/D27503