[PATCH] D29948: [AMDGPU] Restructure runtime metadata creation

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPURuntimeMetadata.h:39
 
+namespace llvm {
 namespace AMDGPU {
----------------
This header file is shared between runtime and compiler. It may not be proper to use namespace llvm here.

Also, changes to this file requires corresponding changes in runtime. Are the runtime changes in place?


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h:57
+
+  virtual void EmitEmitEndOfRuntimeMetadata();
+
----------------
should the name be EmitEndOfRuntimeMetadata?


https://reviews.llvm.org/D29948