[PATCH] D25946: [compiler-rt][asan] Add support for desallocation of unhandled pointers
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 14 10:16:30 PST 2017
rnk added a comment.
In https://reviews.llvm.org/D25946#676423, @etienneb wrote:
> For this given snippet:
> ... snip
Looks right to me.
> HeapValidate is triggering a breakpoint with an invalid address:
> .. snip
That's annoying, but it only happens when you attach a debugger, and I still think this is the right thing to do. The universal CRT actually uses HeapValidate internally in some builds to select between different CRT heaps. Take a look at `select_heap` in `WindowsSDK\10\Source\10.0.14393\ucrt\heap\free_base.cpp`.
https://reviews.llvm.org/D25946
More information about the llvm-commits
mailing list