[PATCH] D29945: [compiler-rt][asan|win] Fix flaky unittest due to large allocations

Etienne Bergeron via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 09:54:04 PST 2017


etienneb added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_coverage_libcdep.cc:180
+#else
   static const uptr kTrEventArrayMaxSize = FIRST_32_SECOND_64(1 << 22, 1 << 30);
+#endif
----------------
rnk wrote:
> I don't think we need the #if:
>   static const uptr kTrEventArrayMaxSize =
>       (SANITIZER_WORDSIZE == 32 || SANITIZER_WINDOWS) ? 1 << 22 : 1 << 30;
> 
It won't affect linux 64-bit  ?


https://reviews.llvm.org/D29945





More information about the llvm-commits mailing list