[PATCH] D29947: Represent all addends with int64_t

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM.

Nice! We probably want to do more uintX -> uint64 conversions.



================
Comment at: ELF/Relocations.h:125
+static inline int64_t getAddend(const typename ELFT::Rela &Rel) {
+  return llvm::SignExtend64 < ELFT::Is64Bits ? 64 : 32 > (Rel.r_addend);
 }
----------------
Remove spaces around <>.

But do you need this? r_addend is a signed type, so it'll be implicitly sign-extended.


https://reviews.llvm.org/D29947