[PATCH] D29759: [SCEV] Cache results during GetMinTrailingZeros query

[Igor Laevsky via Phabricator via llvm-commits]

igor-laevsky marked an inline comment as done.
igor-laevsky added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:4440
 
-uint32_t
-ScalarEvolution::GetMinTrailingZeros(const SCEV *S) {
+static uint32_t GetMinTrailingZerosImpl(const SCEV *S, ScalarEvolution &SE,
+                                        AssumptionCache &AC,
----------------
sanjoy wrote:
> Extracting out the `Impl` function as a static function is somewhat odd -- why did you just keep it as a normal member function?
Idea was to hide implementation details, but both options seem fine to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D29759