[PATCH] D29918: Add StringRef::getAsDouble

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/Support/StringRef.cpp:604
+  if (Status != APFloat::opOK) {
+    if (!AllowInexact || Status != APFloat::opInexact)
+      return true;
----------------
mehdi_amini wrote:
> fuse the two if?
If I fuse the two if it's going to be wrapped by clang-format anyway, and I thought this made it clearer to read.  But I can do it either way, LMK if you still want me to.


https://reviews.llvm.org/D29918