[PATCH] D29918: Add StringRef::getAsDouble
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 13 17:15:56 PST 2017
mehdi_amini added inline comments.
================
Comment at: llvm/include/llvm/ADT/StringRef.h:517
+ bool getAsDouble(double &Result, bool AllowInexact) const;
+
----------------
doc for public API?
================
Comment at: llvm/lib/Support/StringRef.cpp:604
+ if (Status != APFloat::opOK) {
+ if (!AllowInexact || Status != APFloat::opInexact)
+ return true;
----------------
fuse the two if?
https://reviews.llvm.org/D29918
More information about the llvm-commits
mailing list