[PATCH] D28249: Improve scheduling with branch coalescing

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 12:55:28 PST 2017


lei added a comment.

In https://reviews.llvm.org/D28249#672204, @echristo wrote:

> In general pretty happy with this. A few comments inline.
>
> A few top level comments:
>
> What performance testing have you done with this?
>  Looks like SPEC on ppc?
>  Anything else?
>  Same for correctness checking. You mentioned that this doesn't affect ARM and then change a thumb testcase, what's up there?
>
> Thanks!
>
> -eric


Yes, the only performance tests done was SPEC on PPC.
I didn't notice the thumb issue, I'll take another look.


https://reviews.llvm.org/D28249





More information about the llvm-commits mailing list