[PATCH] D29265: [legalize-types] Remove stale entries from SoftenedFloats.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D29265#675246, @chh wrote:

> Could you modify existing fp128 unit tests, especially those for Android target, to run with both current configuration and the "expensive checks". How do you enable the "expensive checks"?
>
> I remember dealing with some differences between SoftenedFloats and ReplacedValues maps, when I twisted various configurations to get fp128 values not softened for some operators and saved in mmx registers. I am afraid that a lot of cases were not tested with the "expensive checks" enabled.


To enable all expensive checks is through a build define: LLVM_ENABLE_EXPENSIVE_CHECKS, to perform it on tests you have to enable the specific check in question, in this case "-enable-legalize-types-checking"

Really we need build bot coverage that has LLVM_ENABLE_EXPENSIVE_CHECKS defined by default, but that can't happen until we have fixed all the current failures.


https://reviews.llvm.org/D29265