[PATCH] D28199: [BypassSlowDivision] Use ValueTracking to simplify run-time checks

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 10:08:32 PST 2017


jlebar added a comment.

> Justin, do you think such refactoring approach should be preferred?

I'm happy to review these additional patches, but I would prefer to have a relatively fast feedback cycle between my reviewing the code and your addressing the comments.  By the time a week has passed, I've already forgotten details about the patch; by the time six weeks pass, I am reviewing totally from scratch.

Do you have time now to push these patches through to completion?  If not, maybe you can let me know when you do, and at that point I'll start reviewing?


https://reviews.llvm.org/D28199





More information about the llvm-commits mailing list