[PATCH] D29898: [Support] Add format_provider for StringLiteral

[Pavel Labath via Phabricator via llvm-commits]

labath created this revision.

Even though it inherits from StringRef, we need to mention it
explicitly, as the formatter selection mechanism does not take
inheritance into account.


https://reviews.llvm.org/D29898

Files:
  include/llvm/Support/FormatProviders.h
  unittests/Support/FormatVariadicTest.cpp


Index: unittests/Support/FormatVariadicTest.cpp
===================================================================
--- unittests/Support/FormatVariadicTest.cpp
+++ unittests/Support/FormatVariadicTest.cpp
@@ -324,11 +324,13 @@
   const char FooArray[] = "FooArray";
   const char *FooPtr = "FooPtr";
   llvm::StringRef FooRef("FooRef");
+  constexpr StringLiteral FooLiteral("FooLiteral");
   std::string FooString("FooString");
   // 1. Test that we can print various types of strings.
   EXPECT_EQ(FooArray, formatv("{0}", FooArray).str());
   EXPECT_EQ(FooPtr, formatv("{0}", FooPtr).str());
   EXPECT_EQ(FooRef, formatv("{0}", FooRef).str());
+  EXPECT_EQ(FooLiteral, formatv("{0}", FooLiteral).str());
   EXPECT_EQ(FooString, formatv("{0}", FooString).str());
 
   // 2. Test that the precision specifier prints the correct number of
Index: include/llvm/Support/FormatProviders.h
===================================================================
--- include/llvm/Support/FormatProviders.h
+++ include/llvm/Support/FormatProviders.h
@@ -46,7 +46,8 @@
 template <typename T>
 struct use_string_formatter
     : public std::integral_constant<
-          bool, is_one_of<T, llvm::StringRef, std::string>::value ||
+          bool, is_one_of<T, llvm::StringRef, llvm::StringLiteral,
+                          std::string>::value ||
                     is_cstring<T>::value> {};
 
 template <typename T>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29898.88219.patch
Type: text/x-patch
Size: 1408 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170213/f50e86d6/attachment.bin>