[PATCH] D29445: LTO: add a code-model flag

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

The code changes look good, but would it be possible to change the test cases to verify that the output uses the correct code model?



================
Comment at: tools/lld/ELF/Config.h:16
 #include "llvm/ADT/StringSet.h"
+#include "llvm/Support/CodeGen.h"
 #include "llvm/Support/ELF.h"
----------------
Remove this line.


================
Comment at: tools/lld/lib/Core/TargetOptionsCommandFlags.cpp:30
+
+llvm::CodeModel::Model lld::GetCodeModelFromCMModel() {
+  return CMModel;
----------------
Suggest renaming to GetCommandLineCodeModel.


Repository:
  rL LLVM

https://reviews.llvm.org/D29445