[PATCH] D29606: PredicateInfo: Handle critical edges

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM (modulo a comment). Nuno, What do you think?



================
Comment at: lib/Transforms/Utils/PredicateInfo.cpp:124-128
+    if (ABlockEdge < BBlockEdge)
+      return true;
+    if (ABlockEdge > BBlockEdge)
+      return false;
+    // Now sort defs before uses
----------------
So, in the case `ABlockEdge == `BBBlockEdge` you fall down and use `Def/U` to determine the ordering. 
Unless I'm missing something, can't this be folded inside the `std::tie()` ? (sorry if I'm terribly mistaken here)


https://reviews.llvm.org/D29606