[PATCH] D29609: [dsymutil] Follow dependencies during ODR uniquing

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap updated this revision to Diff 88087.
alexshap added a comment.

1. llvm-dsymutil with this patch vs current upstream:

alexshap-mbp:~ alexshap$ time ~/TEST_LLVM/build/bin/llvm-dsymutil ~/LLVM/build/bin/clang -o ~/test_dsym_clang.dSYM
real	1m46.835s
user	1m14.014s
sys	0m12.737s
vs
alexshap-mbp:~ alexshap$ time ~/LLVM_CLEAN/build/bin/llvm-dsymutil ~/LLVM/build/bin/clang -o ~/clean_dsym_clang.dSYM
real	1m43.072s
user	1m13.640s
sys	0m12.872s

-although the measurements might be noisy - looks like the perf regressed around 2-3%

alexshap-mbp:~ alexshap$ ls -lh ~/clean_dsym_clang.dSYM/Contents/Resources/DWARF/clang
-rw-r--r--  1 alexshap  THEFACEBOOK\Domain Users   530M Feb 11 02:25 /Users/alexshap/clean_dsym_clang.dSYM/Contents/Resources/DWARF/clang
alexshap-mbp:~ alexshap$ ls -lh ~/test_dsym_clang.dSYM/Contents/Resources/DWARF/clang
-rw-r--r--  1 alexshap  THEFACEBOOK\Domain Users   530M Feb 11 02:29 /Users/alexshap/test_dsym_clang.dSYM/Contents/Resources/DWARF/clang

- the sizes are approximately the same

2. rerun the tests:

Testing Time: 0.73s

  Expected Passes    : 39

[100%] Built target check-llvm-tools-dsymutil


Repository:
  rL LLVM

https://reviews.llvm.org/D29609

Files:
  test/tools/dsymutil/Inputs/odr-fwd-declaration/1.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration/2.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration/3.o
  test/tools/dsymutil/X86/odr-fwd-declaration.cpp
  tools/dsymutil/DwarfLinker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29609.88087.patch
Type: text/x-patch
Size: 8843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170211/306c7969/attachment.bin>