[PATCH] D29734: IR: Function summary extensions for whole-program devirtualization pass.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/trunk/include/llvm/IR/ModuleSummaryIndex.h:253
+  /// An "identifier" for a virtual function. This contains the type identifier
+  /// represented as a GUID and the offset from the address point to the virtual
+  /// function pointer.
----------------
pcc wrote:
> mehdi_amini wrote:
> > `address point`? 
> > 
> > Beyond the typo, I have no idea reading this what is the address pointer referring to? Is it the address of the vtable?
> "address point" is as defined here: https://mentorembedded.github.io/cxx-abi/abi.html#vtable-general
> 
> I can include a reference to that document in the comment perhaps?
I'm a big fan of adding reference to external document/standard in comments indeed. That helps readers that aren't as familiar with the standard. Thks.


Repository:
  rL LLVM

https://reviews.llvm.org/D29734