[llvm] r294729 - [PM] Relax the patterns used in the new test I added because some

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 16:22:01 PST 2017


I think the bug this exposed in loop deletion is fixed in r294810.

On Fri, Feb 10, 2017 at 2:38 PM Vitaly Buka via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> That's true. For hard cases I usually just create empty dir and run there
>  llvm/projects/zorg/zorg/buildbot/builders/sanitizers/buildbot_<bot>.sh
> However it's usually slow as it executes unrelated steps.
>
> Maybe we could, in general, dump entire FileCheck input if test failed?
>
> On Fri, Feb 10, 2017 at 2:27 PM Chandler Carruth <chandlerc at gmail.com>
> wrote:
>
> On Fri, Feb 10, 2017 at 12:03 PM Vitaly Buka via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> Some tests fail probably after this or r294728
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/2652
>
>
> This build bot is simultaneously really useful and really awful.
>
> There are no coherent instructions for how I can reproduce an msan
> bootstrap of Clang. But it does find real issues. The bot seems to be the
> only way I learn of these, which would actually be fine if the output were
> useful, but because of how lit works, the output is completely useless.
>
> Is there any way we can make debugging these failures more reasonable for
> others?
>
> (Anyways, I'm hunting down the use-of-uninit...)
>
>
>
> On Fri, Feb 10, 2017 at 1:00 AM Chandler Carruth via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> Author: chandlerc
> Date: Fri Feb 10 02:48:50 2017
> New Revision: 294729
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294729&view=rev
> Log:
> [PM] Relax the patterns used in the new test I added because some
> compilers don't print the typedef name.
>
> Modified:
>     llvm/trunk/test/Other/loop-pm-invalidation.ll
>
> Modified: llvm/trunk/test/Other/loop-pm-invalidation.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/loop-pm-invalidation.ll?rev=294729&r1=294728&r2=294729&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Other/loop-pm-invalidation.ll (original)
> +++ llvm/trunk/test/Other/loop-pm-invalidation.ll Fri Feb 10 02:48:50 2017
> @@ -51,7 +51,7 @@ define void @one_loop(i1* %ptr) {
>  ; CHECK-LOOP-INV-NEXT: Running analysis: TargetLibraryAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-LOOP-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-LOOP-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -60,11 +60,11 @@ define void @one_loop(i1* %ptr) {
>  ; CHECK-LOOP-INV-NEXT: Clearing all analysis results for: l0.header
>  ; CHECK-LOOP-INV-NEXT: Invalidating analysis: LoopAnalysis
>  ; CHECK-LOOP-INV-NEXT: Invalidating analysis: ScalarEvolutionAnalysis
> -; CHECK-LOOP-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Running pass: FunctionToLoopPassAdaptor<{{.*}}> on
> one_loop
>  ; CHECK-LOOP-INV-NEXT: Running analysis: LoopAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
> -; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-LOOP-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-LOOP-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -78,7 +78,7 @@ define void @one_loop(i1* %ptr) {
>  ; CHECK-SCEV-INV-NEXT: Running analysis: TargetLibraryAnalysis
>  ; CHECK-SCEV-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
>  ; CHECK-SCEV-INV-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -86,10 +86,10 @@ define void @one_loop(i1* %ptr) {
>  ; CHECK-SCEV-INV-NEXT: Invalidating all non-preserved analyses
>  ; CHECK-SCEV-INV-NEXT: Clearing all analysis results for: l0.header
>  ; CHECK-SCEV-INV-NEXT: Invalidating analysis: ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Running pass: FunctionToLoopPassAdaptor<{{.*}}> on
> one_loop
>  ; CHECK-SCEV-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -115,7 +115,7 @@ define void @nested_loops(i1* %ptr) {
>  ; CHECK-LOOP-INV-NEXT: Running analysis: TargetLibraryAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-LOOP-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-LOOP-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -128,11 +128,11 @@ define void @nested_loops(i1* %ptr) {
>  ; CHECK-LOOP-INV-NEXT: Clearing all analysis results for: l.0.0.header
>  ; CHECK-LOOP-INV-NEXT: Invalidating analysis: LoopAnalysis
>  ; CHECK-LOOP-INV-NEXT: Invalidating analysis: ScalarEvolutionAnalysis
> -; CHECK-LOOP-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Running pass: FunctionToLoopPassAdaptor<{{.*}}> on
> nested_loops
>  ; CHECK-LOOP-INV-NEXT: Running analysis: LoopAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
> -; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-LOOP-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-LOOP-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -149,7 +149,7 @@ define void @nested_loops(i1* %ptr) {
>  ; CHECK-SCEV-INV-NEXT: Running analysis: TargetLibraryAnalysis
>  ; CHECK-SCEV-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
>  ; CHECK-SCEV-INV-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -161,10 +161,10 @@ define void @nested_loops(i1* %ptr) {
>  ; CHECK-SCEV-INV-NEXT: Clearing all analysis results for: l.0.header
>  ; CHECK-SCEV-INV-NEXT: Clearing all analysis results for: l.0.0.header
>  ; CHECK-SCEV-INV-NEXT: Invalidating analysis: ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Running pass: FunctionToLoopPassAdaptor<{{.*}}> on
> nested_loops
>  ; CHECK-SCEV-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -200,7 +200,7 @@ define void @dead_loop() {
>  ; CHECK-LOOP-INV-NEXT: Running analysis: TargetLibraryAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-LOOP-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-LOOP-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -209,11 +209,11 @@ define void @dead_loop() {
>  ; CHECK-LOOP-INV-NEXT: Clearing all analysis results for: l0.header
>  ; CHECK-LOOP-INV-NEXT: Invalidating analysis: LoopAnalysis
>  ; CHECK-LOOP-INV-NEXT: Invalidating analysis: ScalarEvolutionAnalysis
> -; CHECK-LOOP-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Running pass: FunctionToLoopPassAdaptor<{{.*}}> on
> dead_loop
>  ; CHECK-LOOP-INV-NEXT: Running analysis: LoopAnalysis
>  ; CHECK-LOOP-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
> -; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-LOOP-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-LOOP-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-LOOP-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-LOOP-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -227,7 +227,7 @@ define void @dead_loop() {
>  ; CHECK-SCEV-INV-NEXT: Running analysis: TargetLibraryAnalysis
>  ; CHECK-SCEV-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
>  ; CHECK-SCEV-INV-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -235,10 +235,10 @@ define void @dead_loop() {
>  ; CHECK-SCEV-INV-NEXT: Invalidating all non-preserved analyses
>  ; CHECK-SCEV-INV-NEXT: Clearing all analysis results for: l0.header
>  ; CHECK-SCEV-INV-NEXT: Invalidating analysis: ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Running pass: FunctionToLoopPassAdaptor<{{.*}}> on
> dead_loop
>  ; CHECK-SCEV-INV-NEXT: Running analysis: ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-NEXT: Finished {{.*}}Loop pass manager run.
> @@ -252,7 +252,7 @@ define void @dead_loop() {
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running analysis:
> TargetLibraryAnalysis
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running analysis:
> ScalarEvolutionAnalysis
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running analysis: TargetIRAnalysis
> -; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Starting {{.*}}Loop pass manager run.
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running pass: NoOpLoopPass
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running pass: LoopDeletionPass
> @@ -262,7 +262,7 @@ define void @dead_loop() {
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running pass:
> InvalidateAnalysisPass<{{.*}}ScalarEvolutionAnalysis
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Invalidating all non-preserved
> analyses
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Invalidating analysis:
> ScalarEvolutionAnalysis
> -; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}LoopAnalysisManager
> +; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Invalidating analysis:
> InnerAnalysisManagerProxy<{{.*}}Loop
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Running pass:
> FunctionToLoopPassAdaptor<{{.*}}> on dead_loop
>  ; CHECK-SCEV-INV-AFTER-DELETE-NEXT: Finished {{.*}}Function pass manager
> run.
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170211/eb02597b/attachment.html>


More information about the llvm-commits mailing list