[PATCH] D26886: [ThinLTO] Implement -pass-remarks-output in ThinLTOCodeGenerator

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: llvm/trunk/lib/LTO/ThinLTOCodeGenerator.cpp:858-863
+        auto DiagFileOrErr = setupOptimizationRemarks(Context, count);
+        if (!DiagFileOrErr) {
+          errs() << "Error: " << toString(DiagFileOrErr.takeError()) << "\n";
+          report_fatal_error("ThinLTO: Can't get an output file for the "
+                             "remarks");
+        }
----------------
davide wrote:
> davide wrote:
> > I'm working on refactoring this so we can share between old and new LTO API. I noticed that if you comment out this block of code, the test still passes. Any ideas on how we can better test this?
> Fixed in r294784.
Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D26886