[PATCH] D29822: [LNT] Get cc info from CMake cache instead of from command-line

[Chris Matthews via Phabricator via llvm-commits]

cmatthews accepted this revision.
cmatthews added a comment.

LGTM. Thanks Kristof!



================
Comment at: lnt/tests/test_suite.py:583
 
-    def _check_call(self, *args, **kwargs):
+    def _check_output(self, *args, **kwargs):
         note('Execute: %s' % ' '.join(args[0]))
----------------
I am not a big fan of using check_output for anything but the simplest uses.  In this case we can't do anything with the output until the command finishes running, and the stderr is not interleaved with the output. And when it fails we give the user a nice exception as an error message.

Our ci scripts in zorg have a much nicer implementation, they print a shell like version of the command that you can paste in your own terminal, stream all the outputs and give real error messages. I will probably try and put them in here some day.  Until then, you have not made this worse :)


================
Comment at: lnt/tests/test_suite.py:800
+            for pattern, varname in pattern2var:
+                m = re.search(pattern, line)
+                if m:
----------------
Would match work here? I think these all end up on the start of line.


https://reviews.llvm.org/D29822