[PATCH] D29840: test-release.sh: Remove workaround for test-suite build

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 12:01:04 PST 2017


tstellar added a comment.

In https://reviews.llvm.org/D29840#673825, @rengolin wrote:

> Well, this checks out the test-suite, which one can link to their LNT directory. I have been bitten before for running dot-release testing on trunk test-suite and spending a while realising it had new tests that weren't present in the original release.
>
> Since we have a flag to disable that, I'm not sure there's value in simply removing it and forcing people to check it out on their own.


The only change with this patch is that by default the test-suite will be checked out to ${tag}/llvm.src/projects rather than ${tag}/, so the test-suite will still be checked out.   Would it be better to keep ${tag}/ as the default location ?  I wasn't sure if the test-suite location mattered given that the test-release.sh script doesn't do anything with it.


https://reviews.llvm.org/D29840





More information about the llvm-commits mailing list