[PATCH] D29838: [asan][win] Force tls_init test to use dynamic runtime

Etienne Bergeron via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 10:59:47 PST 2017


etienneb created this revision.
Herald added a subscriber: kubamracek.

There is no guarantee that the tls_init is executed on the static runtime
(/MT).

On windows 7, this unittest is failing.
On windows 10, I believe it's working because of the new CRT.

On ASAN side, it doesn't matter that the hook point is run or not.
It must be run only if there is other tls_initializer that are registered.


https://reviews.llvm.org/D29838

Files:
  test/asan/TestCases/Windows/tls_init.cc


Index: test/asan/TestCases/Windows/tls_init.cc
===================================================================
--- test/asan/TestCases/Windows/tls_init.cc
+++ test/asan/TestCases/Windows/tls_init.cc
@@ -1,4 +1,4 @@
-// RUN: %clang_cl_asan %s -Fe%t.exe
+// RUN: %clang_cl_asan %s -Fe%t.exe /MD
 // RUN: %run %t.exe | FileCheck %s
 
 // CHECK: my_thread_callback


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29838.88021.patch
Type: text/x-patch
Size: 365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170210/bc5245f3/attachment.bin>


More information about the llvm-commits mailing list